A fully evaluated may still have children nodes #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were historically not displaying children nodes for fully evaluated types, but arguably they used to be displayed whole inline, rather than just the term head. In any case, the right thing to do is to of course display the nodes for fully evaluated terms, and keep printing the term head for the specific variable node. Fixes #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were historically not displaying children nodes for fully evaluated types, but arguably they used to be displayed whole inline, rather than just the term head.
In any case, the right thing to do is to of course display the nodes for fully evaluated terms, and keep printing the term head for the specific variable node.
Fixes #110