This repository has been archived by the owner on May 8, 2024. It is now read-only.
feat: mapping between swerik_ids and biobook references #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ninpnin Pls take a look /merge |
|
Should we open up a new issue to fix the last things? |
|
I think we should add a description in corpus/metadata/README.md . Otherwise looks fine by me. |
ninpnin
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a mapping between swerik IDs and the bio-books.
I found 172 individuals in the mp metadata that didn't make it into the known_mp_catalog, thus not in the mapping. 147 of them have a biobook reference that we know of, but the volume / pages would have to be looked up or fetched from wikidata - is that something we want to handle before merging this file? I need to use it for other stuff, but it can sit in PR for a while.
unreferenced MPs with a biobook reference
unreferenced-mps.csv
the list of IDs not in the mapping file
unreferenced-MPs.txt