Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Swerik ids #441

Merged
merged 35 commits into from
Jan 12, 2024
Merged

Swerik ids #441

merged 35 commits into from
Jan 12, 2024

Conversation

BobBorges
Copy link
Collaborator

This PR:

  • Generated UUID-based "SWERIK" IDs for people and uploaded them to wikidata
  • update queries in pyriksdagen/data to fetch swerik_id
  • added queries for additional info (birth/death place, external IDs, image urls)
  • updates pyriksdagen/wikidata to handle new queries and write results using swerik id as PK
  • add a script and pyriksdagen package to dump person info into a catalog for the swerik website (this will be the formatter url requested in Missing URL to lookup SWERIK politician ID #426 -- swerik-project.github.io/person-catalog/<swerik_id>). Depending when @ninpnin has time to review the PR on the website repo, this could even be up today.
  • minor cleanup -- (rm files that shouldn't be tracked, some formatting issues in code)

Sample of protocols with new database PK to follow.

@BobBorges

This comment was marked as resolved.

@BobBorges
Copy link
Collaborator Author

Maybe @fredrik1984 can check the sample when the person catalog is live on swerik-project.github.io and kill 2 birds with one stone.

@BobBorges
Copy link
Collaborator Author

Perform unit tests / unittest failure is expected at this point, but I don't understand why the schema test fails. @ninpnin?

@MansMeg
Copy link
Collaborator

MansMeg commented Jan 9, 2024

Failing tests

@BobBorges
Copy link
Collaborator Author

@MansMeg one is expected -- only a sample has been pushed. I don't (yet) understand the failure of the other one.

@BobBorges
Copy link
Collaborator Author

not sure what the problem is :| same test passes locally.

image

@BobBorges
Copy link
Collaborator Author

the sample can now be checked using the swerik IDs at swerik-project.github.io/person-catalog/, e.g. the last diff in the sample points to: https://swerik-project.github.io/person-catalog/i-X9jqcGenibr5tWEbnZgddm/
image

@ninpnin
Copy link
Collaborator

ninpnin commented Jan 10, 2024

I checked that the syntax is ok, new IDs exist on our webpage, and the Wiki IDs are the same person as our IDs. 50/50, LGTM

@MansMeg
Copy link
Collaborator

MansMeg commented Jan 10, 2024

Ok so as soon as we get the test cases fixed this will then be merged?

@BobBorges
Copy link
Collaborator Author

With apologies, a new sample will follow. Some stray wiki IDs were left in the protocols. The unit tests will still fail, since the last commit is only a sample.

@BobBorges

This comment was marked as resolved.

@BobBorges
Copy link
Collaborator Author

sample is mostly correct -- incorrect speakers were incorrect before and the mapping between the incorrect wiki id and incorrect swerik id is good. it all has to do with mislabeled notes, so pushing the rest...

@MansMeg
Copy link
Collaborator

MansMeg commented Jan 12, 2024

Great! So this can now be merged?

@BobBorges
Copy link
Collaborator Author

BobBorges commented Jan 12, 2024

Yes! and if we wait 20 minutes for the chairs branch, we can merge that too and do a release :D

@MansMeg
Copy link
Collaborator

MansMeg commented Jan 12, 2024

Yay!

@MansMeg MansMeg merged commit b0624aa into dev Jan 12, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants