-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Maybe @fredrik1984 can check the sample when the person catalog is live on swerik-project.github.io and kill 2 birds with one stone. |
Perform unit tests / unittest failure is expected at this point, but I don't understand why the schema test fails. @ninpnin? |
Failing tests |
@MansMeg one is expected -- only a sample has been pushed. I don't (yet) understand the failure of the other one. |
the sample can now be checked using the swerik IDs at swerik-project.github.io/person-catalog/, e.g. the last diff in the sample points to: https://swerik-project.github.io/person-catalog/i-X9jqcGenibr5tWEbnZgddm/ |
I checked that the syntax is ok, new IDs exist on our webpage, and the Wiki IDs are the same person as our IDs. 50/50, LGTM |
Ok so as soon as we get the test cases fixed this will then be merged? |
…agen-corpus into SWERIK-IDs
With apologies, a new sample will follow. Some stray wiki IDs were left in the protocols. The unit tests will still fail, since the last commit is only a sample. |
This comment was marked as resolved.
This comment was marked as resolved.
…agen-corpus into SWERIK-IDs
sample is mostly correct -- incorrect speakers were incorrect before and the mapping between the incorrect wiki id and incorrect swerik id is good. it all has to do with mislabeled notes, so pushing the rest... |
…agen-corpus into SWERIK-IDs
Great! So this can now be merged? |
Yes! and if we wait 20 minutes for the chairs branch, we can merge that too and do a release :D |
Yay! |
This PR:
Sample of protocols with new database PK to follow.