Skip to content

Commit

Permalink
Bug fix in accepted version list
Browse files Browse the repository at this point in the history
  • Loading branch information
shazad-weka committed Sep 24, 2024
1 parent a05cc18 commit 4b96462
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
2 changes: 1 addition & 1 deletion weka_upgrade_checker/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.3.41
1.3.42
Binary file modified weka_upgrade_checker/weka_upgrade_checker
Binary file not shown.
19 changes: 13 additions & 6 deletions weka_upgrade_checker/weka_upgrade_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

parse = V

pg_version = "1.3.41"
pg_version = "1.3.42"

log_file_path = os.path.abspath("./weka_upgrade_checker.log")

Expand Down Expand Up @@ -719,13 +719,18 @@ def extract_main_version(version):
GOOD("✅ Compute processes CPU utilization ok")

INFO("Validating accepted versions list is empty")
accepted_version = subprocess.check_output(
["weka", "debug", "upgrade", "accepted-versions", "list"]
accepted_version = (
subprocess.check_output(
["weka", "debug", "upgrade", "accepted-versions", "list"]
)
.decode("utf-8")
.strip("\n")
)
if accepted_version != []:

if accepted_version != "[]":
WARN(
"⚠️ Weka clients may have issues auto upgrading after rebooting current accepted version: "
+ " | ".join(accepted_version)
+ " | ".join(str(v) for v in accepted_version)
)
else:
GOOD("✅ Accepted version list is empty")
Expand All @@ -736,7 +741,8 @@ def extract_main_version(version):
.decode()
.strip()
)
if client_target_verion != []:

if client_target_verion != "":
WARN(
f"⚠️ Weka clients will remain on version: {client_target_verion} after upgrading"
)
Expand Down Expand Up @@ -2301,6 +2307,7 @@ def check_os_release(
+ f"version {weka_version}"
)


def weka_agent_check(host_name, result):
weka_agent_status = result
if weka_agent_status != 0:
Expand Down

0 comments on commit 4b96462

Please sign in to comment.