agent: refactor talker.py - split to modules #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doron-cohen
suggested changes
Sep 1, 2019
| WORKDIR /root/talker | ||
|
|
||
| RUN echo {\"password\": null, \"port\": 6379, \"host\": \"redis\", \"host_id\": \"$TALKER_HOST_ID\"} > conf.json | ||
| COPY talker.py talker-service install_agent.sh ./ | ||
| COPY __init__.py agent.py config.py job.py talker.py utils.py install_agent.sh talker_agent/ |
There was a problem hiding this comment.
cant you copy the whole dir?
|
|
||
| CMD ["python", "talker.py"] | ||
| ENV PYTHONPATH=. |
There was a problem hiding this comment.
this is destructive. you need to add the current dir by it's full path
| curl -sfL https://github.com/weka-io/talker/raw/v1.8.1/talker_agent/talker.py > talker_agent/config.py | ||
| curl -sfL https://github.com/weka-io/talker/raw/v1.8.1/talker_agent/talker.py > talker_agent/job.py | ||
| curl -sfL https://github.com/weka-io/talker/raw/v1.8.1/talker_agent/talker.py > talker_agent/talker.py | ||
| curl -sfL https://github.com/weka-io/talker/raw/v1.8.1/talker_agent/utils.py > talker_agent/utils.py |
There was a problem hiding this comment.
this is insane. look at downloading an archive with the full directory
| @@ -1,10 +1,14 @@ | |||
| #!/bin/sh | |||
|
|
|||
| if [ "$DOWNLOAD_TALKER" = true ] ; then | |||
| sudo mkdir -p /root/talker | |||
| sudo mkdir -p /root/talker/talker_agent | |||
There was a problem hiding this comment.
why not keep it in /root/talker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.