Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data script #106

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mohamedsto7y
Copy link

No description provided.

@henrykironde
Copy link
Contributor

@mohamedsto7y this is a good start when creating a Python custom data package. However, looking at the data
self.urls = {"WNVC": "https://ndownloader.figshare.com/files/25525537"}, I do not think that is real data. It looks like a report.
I have tried to checkout where you got that link from to investigate further but I cannot get the page you found this url https://ndownloader.figshare.com/files/25525537 from.

The python script use self.ref as the homepage where you can find the data source link and more info. It should be at least as close as possible for users to find the exact data
Also the name of the data package file should be similar to the name key word or attribute. For example self.name = "west-nile-virus-california" and file name west_nile_virus_california.py

@mohamedsto7y mohamedsto7y changed the title Add data script-west_nile.py Add data script Apr 5, 2021
@mohamedsto7y
Copy link
Author

I changed the script and the whole dataset since it was a table not a complete dataset.Named now decision-making-during-outbreaks-uk.py.

@henrykironde
Copy link
Contributor

  1. File name should use _ while attribute name should use -
    decision_making_during_outbreaks_uk.py decision-making-during-outbreaks-uk

Also after you have those changes. Could you include a command you used to install into postgres. Also open the postgres data and take a screenshot of at least one table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants