apps: feature: pin apps #109
Conversation
|
|
||
| // without a trailing slash | ||
| const xdcget_export = "https://apps.testrun.org"; | ||
| const pinSvg = html`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M12 17v5"/><path d="M9 10.76a2 2 0 0 1-1.11 1.79l-1.78.9A2 2 0 0 0 5 15.24V16a1 1 0 0 0 1 1h12a1 1 0 0 0 1-1v-.76a2 2 0 0 0-1.11-1.79l-1.78-.9A2 2 0 0 1 15 10.76V7a1 1 0 0 1 1-1 2 2 0 0 0 0-4H8a2 2 0 0 0 0 4 1 1 0 0 1 1 1z"/></svg>`; |
There was a problem hiding this comment.
where does this icon come from?
There was a problem hiding this comment.
It seems that the license text is required.
website/apps/main.js
Outdated
| .sort( | ||
| (a, b) => | ||
| Number(isPinned(b.item.app_id)) - Number(isPinned(a.item.app_id)) | ||
| ) |
There was a problem hiding this comment.
this sort can be merged with the previous sort instead of sorting two times
|
Have you checked whether this works on Android / iOS? |
You mean inside DC? Yes, only Android. |
No, I haven't tried. I'm just making sure that the intended effect will be achieved. Edit: FYI this won't affect Delta Chat desktop, because there we have a custom UI. |
I see, I was thinking it was using the same web app, that explains why I could not find a way to change the web app URL LOL. |
|
Please provide a description in the PR summary of what the PR does -- i assume it means each user can pin some apps for themselves, on their own device? What's the reasoning/discussion behind this? |
That's right, I added a description. |
|
thanks a lot for the idea! however, some of us, me included, we were thinking about "pinned apps" more as "featured apps" that are flagged as such in just want to bring that up, tbh, i did not thought much about that yet - quite some devs are in holiday or about to have holidays, or busy with other things, this slows things down ... :) |
|
OK, thanks for explaining, feel free to close the PR if that's the final decision. FWIW I don't think featured apps in the xdcget.ini is a great solution, I mean who decides what's featured and what not? Even for clear options like a poll app, there are like 3 poll apps in the store, which one will be featured? or will all 3 be featured?. And even so what is useful for one user might not be useful for another, that's why I thought every user should have the choice. |
This PR would allow users to pin apps to the top of the list locally, for easy access of each user most used apps, pretty useful since there is a lot of apps in the store and searching for the one you need every time is very annoying.
Screenshot showing a pinned app (poll):
