feat: BitTorrent v2 Support #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
leoherzog
commented
May 12, 2021
|
The assumption is valid, it should have either v1 or v2, or both. |
DiegoRBaquero
changed the title
|
Hey reviewers. What's left to be done to advance this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added support for decoding and encoding of
infoHashV2key for BitTorrent v2 Support.Which issue (if any) does this pull request address?
#88
Is there anything you'd like reviewers to focus on?
I need a hand updating the tests. I'm not familiar with
tape, and I suspect that there are at least a couple of assumptions made in testing that each Torrent object should always must have aninfoHashkey. The new assumption is a valid object can have aninfoHashkey, or aninfoHashV2key, or both.