Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show flex properties in style panel when layout is not flex #722

Merged
merged 4 commits into from
Jan 2, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 30, 2022

Description

  1. What is this PR about (link the issue and add a short description)

Do not show flex properties in the style panel when a layout is not flex
closes #687

image

Here I patched appliesTo of properties alignItems, justifyItems see mdn/data#585

Steps for reproduction

Opens designer panel, check no flex props in display: block layout

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Dec 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview Jan 2, 2023 at 10:02AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When layout is not flex, we shouldn't show flex properties in style panel
2 participants