Update fastly-rails to use latest fastly-ruby #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastly-rails hasn’t been updated in over 2 years. With the release of factly-ruby 2.3.0, that adds thread safety and concurrency, this gem needs to be updated as well.
Changes:
- update factly-ruby to 2.3.0
- factory_girl_rails is deprecated, migrate to factory_bot_rails
- remove old appraisals (deprecated ruby and rails versions and conflicts with bundler update to 2.0)
- test ruby 2.6.3 and rails 5.2.3
- fix test failures (get :show, params: {})
- fix minitest deprecations (asset_nil)
- Rails 5 before_action
- Ruby 2.6.3, 2.5.5, 2.4.6 - Rails 4.2.11.1, 5.2.3 - fix assert_equal in fastly-rails.test for user and password
…bundler 2.0 and < Rails 5 require < bundler 2.0, and > Rails 5 requires bundler 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
fastly#86