Migration #213
Merged
Migration #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ericvalcik
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
I love the changes, the design is cleaner in my opinion too. About the comments I made, I'd create issues from some of them, but I felt like we can discuss them in this PR before we make issues from the comments I made.
I think the best would be to just discuss some of the possible changes here, but let's not make the changes in this PR - let's create GitHub issues for the stuff we will want to fix and fix those issues in new, smaller PRs.
👍 Approved, nice work.
ericvalcik
reviewed
Aug 23, 2023
ericvalcik
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces: