Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Change app.js and README to better reflect actual solution code #26

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Change app.js and README to better reflect actual solution code #26

wants to merge 49 commits into from

Commits on Dec 17, 2020

  1. notes on running tutorial...

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    78c0faf View commit details
    Browse the repository at this point in the history

  2. hooray for gitbash being noninteractive?

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    1552351 View commit details
    Browse the repository at this point in the history

  3. interactive mode all the time.

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    ba51bce View commit details
    Browse the repository at this point in the history

  4. firebase has changed since tutorial written, I think.

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4af5ef7 View commit details
    Browse the repository at this point in the history

  5. create the room code.

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a2a0a98 View commit details
    Browse the repository at this point in the history

  6. join the room code

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    bc913a6 View commit details
    Browse the repository at this point in the history

  7. I hate tutorials that are not written well or maintained...

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    7c0a882 View commit details
    Browse the repository at this point in the history

  8. so annoyed.

    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    fbe1bec View commit details
    Browse the repository at this point in the history

  9. overwriting with original from the parent repo

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8473c50 View commit details
    Browse the repository at this point in the history

  10. Copying the instructions so I can make the better.

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    0b4a67a View commit details
    Browse the repository at this point in the history

  11. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2d0b258 View commit details
    Browse the repository at this point in the history

  12. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    0eb3255 View commit details
    Browse the repository at this point in the history

  13. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    3416c90 View commit details
    Browse the repository at this point in the history

  14. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    fce0d9f View commit details
    Browse the repository at this point in the history

  15. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    16b0185 View commit details
    Browse the repository at this point in the history

  16. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2dfc596 View commit details
    Browse the repository at this point in the history

  17. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    12510d1 View commit details
    Browse the repository at this point in the history

  18. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    654ca0e View commit details
    Browse the repository at this point in the history

  19. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8920e3a View commit details
    Browse the repository at this point in the history

  20. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    e85d459 View commit details
    Browse the repository at this point in the history

  21. okay it's bed time, this isn't complete but at least it's better.

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5060916 View commit details
    Browse the repository at this point in the history

  22. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9742817 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. gonna pick this apart to reverse engineer 'start'

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    72a5681 View commit details
    Browse the repository at this point in the history

  2. remove the room ref code from solution

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a193598 View commit details
    Browse the repository at this point in the history

  3. fix 'create the room' instructions

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    5c6fe7d View commit details
    Browse the repository at this point in the history

  4. remove the room ref code from solution

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6c59901 View commit details
    Browse the repository at this point in the history

  5. remove the join room code from solution

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    aa83102 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:meldaravaniel/FirebaseRTC

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6aa20bf View commit details
    Browse the repository at this point in the history

  7. fixed the collect ice candidates step

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    002ed6c View commit details
    Browse the repository at this point in the history

  8. Update correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    225d3a3 View commit details
    Browse the repository at this point in the history

  9. removed iceCollection and made match solution code, without spoilers

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    1e8e2eb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:meldaravaniel/FirebaseRTC

    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ca64579 View commit details
    Browse the repository at this point in the history

  11. fix empty codelab starting point 

    This version did not match the solution correctly and made it confusing to do the tutorial without just looking at the solution code.  I copied the (also changed) solution app.js into this and removed the code sections that are to be added by the tutorial.
    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    f4279cd View commit details
    Browse the repository at this point in the history

  12. Delete app_solution.js

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ce84293 View commit details
    Browse the repository at this point in the history

  13. add links

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    236c5a3 View commit details
    Browse the repository at this point in the history

  14. Delete personalNotes.md

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    ce51e50 View commit details
    Browse the repository at this point in the history

  15. adding the corrected instructions to the README. 

    I don't know how to update the actual instructions website, so barring that...I enhanced the readme to include them.
    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b674413 View commit details
    Browse the repository at this point in the history

  16. Delete correctedCodelab.md

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    83e6a49 View commit details
    Browse the repository at this point in the history

  17. Update README.md

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    fed80da View commit details
    Browse the repository at this point in the history

  18. Update README.md

    @meldaravaniel
    meldaravaniel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e355e92 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. updated README with corrections and suggestions

    @natkuhn
    natkuhn committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    8e1d682 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from natkuhn/master 

    updated README with corrections and suggestions
    @meldaravaniel
    meldaravaniel committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    fbfad4f View commit details
    Browse the repository at this point in the history

  3. adding a missing word :)

    @meldaravaniel
    meldaravaniel committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    68ae060 View commit details
    Browse the repository at this point in the history

  4. formatting

    @meldaravaniel
    meldaravaniel committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    dbcedd3 View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @meldaravaniel
    meldaravaniel committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    7c8bcea View commit details
    Browse the repository at this point in the history

  6. removing sh from commands in favor of bash-based

    @meldaravaniel
    meldaravaniel committed Dec 19, 2020
    1 Configuration menu
    Copy the full SHA
    81fa0e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Update README.md

    @meldaravaniel
    meldaravaniel committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    993c53f View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. minor readme fixes 

    * fix template string for log message
* add indentation level in session description listener code
    @Fusselwurm
    Fusselwurm committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a3f4004 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge pull request #2 from Fusselwurm/patch-1 

    minor Readme fixes
    @meldaravaniel
    meldaravaniel committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a1cef75 View commit details
    Browse the repository at this point in the history