Skip to content

DTLS: crypto_ccm.rs implementation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

ymtdzzz
Copy link
Contributor

@ymtdzzz ymtdzzz commented Nov 26, 2020

related issue: #13

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #22 (f393d82) into master (9fb3e47) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   48.45%   48.34%   -0.12%     
==========================================
  Files         136      137       +1     
  Lines        7366     7383      +17     
  Branches     1495     1497       +2     
==========================================
  Hits         3569     3569              
- Misses       2782     2799      +17     
  Partials     1015     1015              
Impacted Files Coverage Δ
dtls/src/crypto/crypto_ccm.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb3e47...493c104. Read the comment docs.

@ymtdzzz ymtdzzz marked this pull request as ready for review November 30, 2020 00:32
@ymtdzzz
Copy link
Contributor Author

ymtdzzz commented Nov 30, 2020

@rainliu
I've implemented crypto_ccm.rs and also added a simple test case.

The test case doesn't exist in Pion, so please let me know if you don't need it as it can be covered by another test case. I'll remove it.

Coverage check fail seems to be related to rust-lang/rust#79487 .

@ymtdzzz ymtdzzz changed the title DTLS: [WIP] crypto_ccm.rs implementation DTLS: crypto_ccm.rs implementation Nov 30, 2020
@rainliu rainliu merged commit 06320ba into webrtc-rs:master Nov 30, 2020
@rainliu
Copy link
Member

rainliu commented Nov 30, 2020

@zeroclock, thank you for adding crypto_ccm.rs and corresponding test case.

@ymtdzzz ymtdzzz deleted the dtls/crypto_ccm branch November 30, 2020 04:59
algesten pushed a commit that referenced this pull request Aug 23, 2022
Prevent UDP mux from removing connections
algesten pushed a commit that referenced this pull request Aug 23, 2022
* update deps + loosen some requirements

rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
  then you should specify 0.3.17, which actually means "0.3.y where y >=
  17"
- for crates the are above or equal v1.0 -> specify only major version
  if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions

* fix warnings

* bump min version

error: package `pkcs8 v0.9.0` cannot be built because it requires rustc
1.57 or newer, while the currently active rustc version is 1.56.1

* update util version

* use cargo cache in minimal-versions job

* Revert "use cargo cache in minimal-versions job"

This reverts commit d58d33f175e7bc103347e7a80548ae64775713b5.

* update oid-registry, x509-parser and der-parser

* update rcgen

* update x509-parser

 and restrict hkdf and curve25519-dalek versions so minimal-dependencies
 job passes on CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants