Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Open and highlight correct workflow form section on tab click #2463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Open and highlight correct workflow form section on tab click #2463

wants to merge 2 commits into from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Mar 5, 2025

Fixes #2461

Changes

Opens workflow form section when clicking on section navigation link, fixing issue with scroll position impacting unopened panels.

Manual testing

  1. Log in as crawler
  2. Go to New Workflow
  3. Click section in side navigation. Verify section is scrolled to expands
  4. Scroll and interact with the page. Verify scroll indicator works as expected

@SuaYoo SuaYoo requested review from ikreymer, Shrinks99 and emma-sg March 5, 2025 18:42
emma-sg
emma-sg approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

@Shrinks99 Shrinks99 Awaiting requested review from Shrinks99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect workflow form section highlighted
2 participants
@SuaYoo @emma-sg