Fix max pages quota setting and display #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Feb 10, 2025
•
ikreymer
commented
- add ensure_page_limit_quotas() which sets the config limit to the max pages quota, if any
- set the page limit on the config when: creating new crawl, creating configmap
- don't set the quota page limit on new or existing crawl workflows (remove setting it on new workflows) to allow updated quotas to take affect for next crawl
- frontend: correctly display page limit on workflow settings page from org quotas, if set.
- operator: get org on each sync in one place
- fixes [Bug]: Page limit from quotas is not always being set correctly. #2369
tw4l
approved these changes
Feb 10, 2025
- add ensure_page_limit_quotas() which sets the limit to the quota - set the page limit when: creating new crawl, creating configmap, returning crawl workflow - don't set the quota page limit on new or existing crawl workflows (remove setting it on new workflows) to allow updated quotas to take affect for next crawl - fixes #2369
SuaYoo
force-pushed
the
issue-2369-fix-page-limit-quotas
branch
from
646990e to
2931b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.