Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5657 +/- ##
==========================================
+ Coverage 83.57% 83.65% +0.07%
==========================================
Files 11 11
Lines 1924 1939 +15
Branches 707 718 +11
==========================================
+ Hits 1608 1622 +14
- Misses 283 284 +1
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@bjohansebas looks good for me to using glob and globSync |
| ? globSync(item, { cwd: watchOptions.cwd, absolute: true }) | ||
| : item, | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Do we really need it? Can you provide cases where we broken without it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unlike #5374, which tries to keep native glob support in dev-server to maintain compatibility, this one doesn’t, instead, it simply removes it and shows how to replicate it. That’s also what rspack did in its dev-server, and I don’t think we should be doing external magic just to preserve that support.
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI