Backport security fix from v5.2.1 to version-4 (non-Chromium browser dev-server vulnerability) #5534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backported the security patch from
v5.2.1
to theversion-4
branch to prevent dev client injection into unauthorized or potentially malicious browsers via the/webpack-dev-server
route.What This Fixes
User-Agent
detectionContext
Relevant to: #5313
Inspired by: #5315 (official v5.2.1 patch)
Since
[email protected]
depends on[email protected]
, and upgrading to v5 is not always viable for projects in production, this patch brings essential security hardening to the v4 codebase.Implementation Details
isTrustedClient()
helper to verify presence ofwebpack-dev-server-client
header/webpack-dev-server
route now denies access (403) if the required header is missingThanks for considering this backport 🙏
Happy to adjust based on any review feedback.