cli(node): Add node flags to CLI #377

matheus1lva · 2018-04-07T02:43:38Z

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Test added, i'm not really sure if that it is enough. If it is not, let me know. Since node has quite a few flags, i don't think testing each of them is a good thing.

If relevant, did you update the documentation?
To be updated. Just double checking: this update has to go in the webpack docs, or internal docs?

Summary
This is a feature implementation based on #289.
This pr introduces a way to pass down node flags to execute the cli. To be able to differenciate these flags, a prefix is added to them. E.g. --node.max_old_value=2048. At the end, this allows us to accept every single node flag, without having to compare every single one.

Does this PR introduce a breaking change?
no

ematipico · 2018-04-07T17:26:36Z

This is awesome! There's a problem with your commit message, that's the reason of the broken build. Try to amend your commit and remove the "." (full stop).

About the test, I guess one is enough. After all, they are node flags, not ours. Thanks for your PR!

matheus1lva · 2018-04-07T17:36:55Z

Ok! I was not sure why it was breaking though. I'm fixing it. *Edit* Done!

webpack-bot · 2018-04-07T17:59:14Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

ematipico · 2018-04-09T13:44:58Z

Is your branch rebased from master? I don't get why appveyor build is failing

matheus1lva · 2018-04-09T13:46:02Z

Me neither... let me try once again rebasing this, i had already. Just a second.

matheus1lva · 2018-04-09T13:58:44Z

@ematipico now it should be updated. By some reason when i ran git rebase master it was not finding differences... anyways. Let's just wait for the cis to run. I'm going to keep my eyes on this.

montogeek · 2018-04-09T14:20:21Z

This shouldn't be inside webpack-cli, if an user need custom Node flags, use it on node binary, not webpack-cli.

matheus1lva · 2018-04-09T14:54:16Z

@ematipico it is going to fail again though! As you can see it has been rebased with master.

@montogeek It is not a big change, won't increase code complexity nor anything else. Other projects support this, it is nice to have.

evenstensberg

Good stuff, awesome job! :L

evenstensberg · 2018-04-10T13:42:29Z

Regarding the rationale around accessing node flags in webpack. This is good for us, cause people use webpack inside Docker, CI's etc. It's pretty nice when you can tap directly into v8 or nodeJS for profiling or perf optimizations. I'm in favor for this.

evenstensberg · 2018-04-10T13:43:20Z

@bmeurer thoughts?

montogeek · 2018-04-10T13:45:24Z

@ev1stensberg If the can pass flags to webpack bin, can as well pass them to node.

evenstensberg · 2018-04-10T13:47:23Z

@montogeek not necessarily. The process won't pick the flags up

montogeek · 2018-04-10T13:48:16Z

@ev1stensberg How so?

matheus1lva · 2018-04-10T13:49:17Z

What @montogeek is trying to say is: if someone can call npm run build || npm run something they can call: node --max_old_memory=1024 ./node_modules/.bin/webpack ... as well.

boneskull · 2018-04-10T18:01:44Z

See nodejs/node#19335

bmeurer · 2018-04-10T18:05:02Z

I don't have a strong opinion here, but I tend to agree with @playma256.

boneskull · 2018-04-10T18:15:39Z

Mocha does this same thing. Why? The ability to pass flags directly to the executable is a better user experience.

ematipico · 2018-04-10T19:16:49Z

I really like this feature and as @boneskull pointed out, the user experience improves

ematipico

Let's merge it!

matheus1lva · 2018-04-13T17:16:29Z

@ematipico i've ran the tests and compared the heap consumption for each of them, i've compared master and this branch, both are almost the same (considering the marging of error...)

I removed the tests i added. Let me see how ci behaves.

matheus1lva · 2018-04-15T17:40:56Z

After further investigation, i could not find from where this possible "memory leak" is coming from. I gathered the amount of memory being used by each test, from master and from this branch, both tests are the same. Locally the tests run perfect, without any problem.

At first i suspected that every single command you ran was going though this if statement, but endedup up not being true. Could someone give me a hand on this? I ran out of ideas on how to debug this properly.

ematipico · 2018-04-16T08:32:02Z

bin/process-node-flags.js

+const spawn = require("cross-spawn");
+const path = require("path");
+
+module.exports = function(argv) {


Could you add some jsdoc comments here?

ematipico

I would add a second test with node flags and webpack flags as well, in order to make sure that they don't collide

ematipico · 2018-04-16T08:34:34Z

bin/webpack.js

+
+	if (nodeFlags.length) {
+		require("./process-node-flags")(process.argv);
+		return;


Why there's a return here?

Same reason as used here. If we don't exit, yargs will warn saying these flags are unknown and the normal cli flow will follow, with this return, the other file can strip those flags, spawn another webpack-cli process and work as intended.

Tests added. Let me know if they aren't enough. I've tried to add as many flags as possible.

Okay great, thanks!

ematipico · 2018-04-21T08:42:28Z

@ev1stensberg do you have any idea why appveyor goes out of memory during the tests?

webpack-bot · 2018-04-21T14:06:23Z

@ev1stensberg Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

* use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now

* fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command

* chore(monorepo): move to lerna * chore(monorepo): use commands as normal instead of package * fix(revert): packagejson * chore(monorepo): prune files and update eslint rules * chore(monorepo): fix the no-missing-require error * chore(monorepo): fix typo * chore(monorepo): fix typo * chore(monorepo): prune package json * chore(monorepo): merge package lock json * chore(monorepo): updated package.json * chore(monorepo): fix plugin package.json * chore(cli): move to lerna and scoped packages (#434) * fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command * chore(linting): resolve linter errors * chore(linting): fix linting errors * chore(linting): resolve linting * chore(linting): resolve linting * chore(scaffold): move addons to scaffold * chore(scaffold): fix linting errors * cli(prompt): initial comment for prompt file * cli(prompt): wip * fix(monorepo): fix lint errors * fix(monorepo): fix cross spawn versions * fix(monorepo): update lock files * fix(monorepo): fix versions in pacakges * chore(rebase): refactor stuff * cli(pkgs): re-add entries * chore(v): revise pkg * v0.0.1 * chore(v): revise some deps * v0.0.2 * v0.0.3 * chore(v): back to v1 * v0.0.2 * v0.0.3 * v0.0.4 * chore(deps): update deps * chore(prompt): revise prompt cmd * v0.0.5 * cli(path): resolve better * v0.0.6 * chore(v.6): update init * chore(pkg): v.6 on next * chore(monorepo): add bootstrap to run chore(monorepo): add bootstrap to ci * chore(monorepo): fix appveyor build * chore(monorepo): fix appveyor build * chore(monorepo): add eslint-plugin-prettier * chore(monorepo): fix appveyor build chore(monorepo): fix appveyor build chore(monorepo): add eslint-plugin-prettier chore(monorepo): use nohoist * chore(monorepo): fix versions and use clean bootstrap * chore(monorepo): add rimraf globally chore(monorepo): revert back * chore(monorepo): fix windows build * cli(color): don't use color on non-tty (#452) * Added yarn lock file to gitignore (#455) * chore(next): dev version bump * chore(monorepo): fix windows build * cli(symlinks): Fix paths (#453) * cli(symlinks): fix symlinks * chore(linting): resolve linting errors * chore(rebase): remove old file * cli(init): Better defaults (#451) * cli(init): set default generator name * cli(init): better defaults * chore(rebase): remove old commit * cli(init): fix broken ast and merge scaffolds * chore(docs): better defaults * chore(lint): fix linting errors * chore(deps): remove path from dep installation * chore(resolve): resolve conflicts * fix(vulnerabilities): vulnerabilities patch for v3 (#460) * chore(dependencies): fix vulnerabilities * misc(scripts): update clean:all script * chore(dependencies): fix vulnerabilities * tests(parser): fix recursive-tests signature (#470) * chore(deps): add lerna * tests(coverage): fix coverage (#473) * test(coverage): fix coverage * test(binTestCases): run bintestcases on upper-repo * tests(travis): add node 10 * tests(cov): use regular nyc on tests * chore(lockfile): update pkglock * chore(semantic): configure plugins (#475) * fix(cli): show help flag when defaults fail (#466) * fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format * tests(no-options): refactor tests * ast(parser): add (#456) * ast(parser): add, update, remove - literal node support * ast(parser): add command * ast(util): update property, early exit * tests(add): resursive add ast * tests(add): update recursive parser snaps * misc(conflicts): resolve conflicts * tests(parser): update tests, inputs * chore(review): fix some things * ast(utils): add ast-path safe traverse and type support * ast(utils): merge update property with add property * tests(ast): add tests for safe traversals * misc(fixes): review comments * tests(ast): add tests for addProperty * misc(fixes): review comments * misc(fixes): review comments * misc(fixes): review comments * cli(add): re-add add command

webpack-bot added PR: unreviewed PR: CI-not-ok labels Apr 7, 2018

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Apr 7, 2018

ematipico added the Semver: minor ⚙️ When delivering new features that don't break label Apr 9, 2018

ematipico requested review from dhruvdutt and evenstensberg April 9, 2018 07:16

dhruvdutt approved these changes Apr 9, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Apr 9, 2018

evenstensberg approved these changes Apr 10, 2018

View reviewed changes

ematipico approved these changes Apr 10, 2018

View reviewed changes

matheus1lva added 5 commits April 15, 2018 15:16

feat: add support for node flags

fbcb792

tests: Fix node-flags test

35c2961

misc: Fix test failing due to not-found webpack-cli

ba81985

misc: remove comment

1e824af

misc: refactor removing unecessary args

65c0ab1

ematipico reviewed Apr 16, 2018

View reviewed changes

ematipico suggested changes Apr 16, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Apr 16, 2018

ematipico reviewed Apr 16, 2018

View reviewed changes

tests: add more tests to prevent argument collision

03e9f0e

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Apr 16, 2018

ematipico approved these changes Apr 17, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 17, 2018

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Apr 21, 2018

evenstensberg changed the title ~~Add node flags to CLI~~ cli(node): Add node flags to CLI Apr 28, 2018

evenstensberg merged commit 05204f8 into webpack:master Apr 30, 2018

evenstensberg mentioned this pull request May 7, 2018

(WIP) Cli node flags #439

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli(node): Add node flags to CLI #377

cli(node): Add node flags to CLI #377

matheus1lva commented Apr 7, 2018 •

edited

Loading

ematipico commented Apr 7, 2018 •

edited

Loading

matheus1lva commented Apr 7, 2018 via email •

edited

Loading

webpack-bot commented Apr 7, 2018

ematipico commented Apr 9, 2018

matheus1lva commented Apr 9, 2018

matheus1lva commented Apr 9, 2018

montogeek commented Apr 9, 2018

matheus1lva commented Apr 9, 2018 •

edited

Loading

evenstensberg left a comment

evenstensberg commented Apr 10, 2018

evenstensberg commented Apr 10, 2018

montogeek commented Apr 10, 2018

evenstensberg commented Apr 10, 2018

montogeek commented Apr 10, 2018

matheus1lva commented Apr 10, 2018 •

edited

Loading

boneskull commented Apr 10, 2018

bmeurer commented Apr 10, 2018

boneskull commented Apr 10, 2018

ematipico commented Apr 10, 2018

ematipico left a comment

matheus1lva commented Apr 13, 2018

matheus1lva commented Apr 15, 2018

ematipico Apr 16, 2018 •

edited

Loading

ematipico left a comment

ematipico Apr 16, 2018

matheus1lva Apr 16, 2018

matheus1lva Apr 16, 2018

evenstensberg Apr 17, 2018

ematipico commented Apr 21, 2018 •

edited

Loading

webpack-bot commented Apr 21, 2018

cli(node): Add node flags to CLI #377

cli(node): Add node flags to CLI #377

Conversation

matheus1lva commented Apr 7, 2018 • edited Loading

ematipico commented Apr 7, 2018 • edited Loading

matheus1lva commented Apr 7, 2018 via email • edited Loading

webpack-bot commented Apr 7, 2018

ematipico commented Apr 9, 2018

matheus1lva commented Apr 9, 2018

matheus1lva commented Apr 9, 2018

montogeek commented Apr 9, 2018

matheus1lva commented Apr 9, 2018 • edited Loading

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg commented Apr 10, 2018

evenstensberg commented Apr 10, 2018

montogeek commented Apr 10, 2018

evenstensberg commented Apr 10, 2018

montogeek commented Apr 10, 2018

matheus1lva commented Apr 10, 2018 • edited Loading

boneskull commented Apr 10, 2018

bmeurer commented Apr 10, 2018

boneskull commented Apr 10, 2018

ematipico commented Apr 10, 2018

ematipico left a comment

Choose a reason for hiding this comment

matheus1lva commented Apr 13, 2018

matheus1lva commented Apr 15, 2018

ematipico Apr 16, 2018 • edited Loading

Choose a reason for hiding this comment

ematipico left a comment

Choose a reason for hiding this comment

ematipico Apr 16, 2018

Choose a reason for hiding this comment

matheus1lva Apr 16, 2018

Choose a reason for hiding this comment

matheus1lva Apr 16, 2018

Choose a reason for hiding this comment

evenstensberg Apr 17, 2018

Choose a reason for hiding this comment

ematipico commented Apr 21, 2018 • edited Loading

webpack-bot commented Apr 21, 2018

matheus1lva commented Apr 7, 2018 •

edited

Loading

ematipico commented Apr 7, 2018 •

edited

Loading

matheus1lva commented Apr 7, 2018 via email •

edited

Loading

matheus1lva commented Apr 9, 2018 •

edited

Loading

matheus1lva commented Apr 10, 2018 •

edited

Loading

ematipico Apr 16, 2018 •

edited

Loading

ematipico commented Apr 21, 2018 •

edited

Loading