Skip to content

Commit

Permalink
chore(cli): drop nodejs 8 from ci
Browse files Browse the repository at this point in the history
  • Loading branch information
smelukov committed Jan 29, 2020
1 parent d853b79 commit a0e8036
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
4 changes: 0 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ language: node_js
node_js:
- "12"
- "10"
- "8"
cache:
directories:
- ~/.npm
Expand All @@ -20,9 +19,6 @@ matrix:
- os: linux
node_js: "10"
env: JOB_PART=integration
- os: linux
node_js: "8"
env: JOB_PART=integration

before_install:
- "[[ $(node -v) =~ ^v9.*$ ]] || npm install -g npm@latest" # skipped when using node 9
Expand Down
4 changes: 1 addition & 3 deletions azure-pipelines-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ jobs:
node-12:
node_version: ^12.0.0
node-10:
node_version: ^10.10.0
node-8:
node_version: ^8.12.0
node_version: ^10.13.0
steps:
- task: NodeTool@0
inputs:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"main": "cli.js",
"engines": {
"node": ">=8.0.0"
"node": ">=10.13.0"
},
"keywords": [
"webpack",
Expand Down
2 changes: 1 addition & 1 deletion test/node/node.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { run, extractSummary } = require('../utils/test-utils');
describe('node flags', () => {
it('is able to options flags to node js', done => {
const { stdout, stderr } = run(__dirname, ['--node-args', `--require=${resolve(__dirname, 'bootstrap.js')}`, '--node-args', `-r ${resolve(__dirname, 'bootstrap2.js')}`, '--output', './bin/[name].bundle.js'], false);
expect(stderr).toContain('');
expect(stderr).toBe('');
expect(stdout).toContain('---from bootstrap.js---');
expect(stdout).toContain('---from bootstrap2.js---');
const summary = extractSummary(stdout);
Expand Down

0 comments on commit a0e8036

Please sign in to comment.