Skip to content

refactor: reduce glob-to-regexp dependency#312

Merged
alexander-akait merged 1 commit into
mainfrom
refactor-dep
Jun 11, 2026
Merged

refactor: reduce glob-to-regexp dependency#312
alexander-akait merged 1 commit into
mainfrom
refactor-dep

Conversation

@hai-x

@hai-x hai-x commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce?

Move glob-to-regexp into core as lib/util/globToRegExp.js, specialized for watchpack's only call site (extended and globstar always enabled), and drop the runtime dependency.

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

Use of AI

Yes

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f2f0ea9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hai-x hai-x force-pushed the refactor-dep branch 3 times, most recently from 6f881f5 to 229890c Compare June 10, 2026 17:01
@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing refactor-dep (f2f0ea9) with main (8869686)

Open in CodSpeed

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.87719% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (8869686) to head (f2f0ea9).

Files with missing lines Patch % Lines
lib/util/globToRegExp.js 48.57% 53 Missing and 1 partial ⚠️
lib/index.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   95.87%   91.91%   -3.97%     
==========================================
  Files           7        8       +1     
  Lines        1189     1299     +110     
  Branches      352      384      +32     
==========================================
+ Hits         1140     1194      +54     
- Misses         44       99      +55     
- Partials        5        6       +1     
Flag Coverage Δ
integration 91.91% <50.87%> (-3.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit 52c0e90 into main Jun 11, 2026
47 of 49 checks passed
@alexander-akait alexander-akait deleted the refactor-dep branch June 11, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants