Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Mar 18, 2020

this PR contains

  • update babel packages to @babel/*
  • removed un-necessary babel plugin for spread operation of objects

No changes in source code and the site is working fine with no changes

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep import as is

@anikethsaha
Copy link
Member Author

getting this

image

while running in yarn start for es6 style webpack config.

I am using node 10

@montogeek
Copy link
Member

Why is this change from npm to yarn necessary?

@anikethsaha
Copy link
Member Author

The main docs site is using yarn as well. so I thought of keeping it consistent !
do you want this in npm ?

@EugeneHlushko
Copy link
Member

Lets not, this is separate package with many differences from docs repo

@anikethsaha anikethsaha changed the title chore: removed package-lock.json and added yarn.lock chore: update dependencies Apr 11, 2020
"@babel/core": "^7.7.4",
"@babel/preset-env": "^7.7.4",
"@babel/preset-react": "^7.7.4",
"@babel/register": "^7.9.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@babel/register" was required as I think they moved out the register from the core

@anikethsaha
Copy link
Member Author

cc @montogeek @evilebottnawi @EugeneHlushko Let me know if the current changes are fine.

@EugeneHlushko
Copy link
Member

The new bundle is much bigger, i dont think its fine

@anikethsaha
Copy link
Member Author

may be because of whatwg-fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants