-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #25
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep import
as is
Why is this change from npm to yarn necessary? |
The main docs site is using yarn as well. so I thought of keeping it consistent ! |
Lets not, this is separate package with many differences from docs repo |
"@babel/core": "^7.7.4", | ||
"@babel/preset-env": "^7.7.4", | ||
"@babel/preset-react": "^7.7.4", | ||
"@babel/register": "^7.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@babel/register"
was required as I think they moved out the register from the core
cc @montogeek @evilebottnawi @EugeneHlushko Let me know if the current changes are fine. |
The new bundle is much bigger, i dont think its fine |
may be because of |
this PR contains
@babel/*
No changes in source code and the site is working fine with no changes