Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exports and imports array target resolving #429

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

alexander-akait
Copy link
Member

fixes #400

@alexander-akait alexander-akait merged commit f57c7c4 into main Jul 23, 2024
23 checks passed
@alexander-akait alexander-akait deleted the issue-400 branch July 23, 2024 14:13
@hardfist
Copy link

@alexander-akait does this deprecate https://webpack.js.org/guides/package-exports/#alternatives behavior? will this be shipped in webpack@5?

@alexander-akait
Copy link
Member Author

@hardfist we should rewrite our docs because we are align with Node.js behaviour right now

@alexander-akait
Copy link
Member Author

@hardfist
Copy link

hardfist commented Aug 1, 2024

@hardfist we should rewrite our docs because we are align with Node.js behaviour right now

@alexander-akait one of our internal webpack projects break because of this change, I'm not sure whether should provide a option to change this behavior would be better, but it's indeed a breaking change and change the default value in next big version seems better?

@alexander-akait
Copy link
Member Author

@hardfist Technically you are right, but I would say it is better to fix it in the project, because relying on behavior that was initially designed incorrectly is not the best idea, most likely it would break in other bundlers and in the node itself, as workarund you can fix old version or just copy paste our old code (as a plugin) and set other stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM: package.exports array target not conforming to the ESM specification
3 participants