Send websocket message for comments #3835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsisak
added
new-feature
1 task
itsisak
commented
May 12, 2025
Comment on lines
19
to
+23
| def to_representation(self, value): | ||
| return None | ||
| try: | ||
| return instance_to_string(value) | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Dont know why GenericRelationField was write-only, it prevented comments from returning content_target. If it should stay how it was, it is easy enough to add it to the websocket meta data instead of this.
itsisak
force-pushed
the
comment-websockets
branch
from
f2a5963 to
212caca
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
- Coverage 89.97% 89.79% -0.19%
==========================================
Files 763 767 +4
Lines 24401 24477 +76
==========================================
+ Hits 21956 21978 +22
- Misses 2445 2499 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send websocket messages for new comments and deleted comments.
Currently a bit unsure of how i should implement the groups.
There should imo be a seperate group for each comment section, such that you only get messages from those you have access to (eg. "comments-events.event-1"). The issue is that always connecting to all groups a user has access to seems inefficient since there exists so many events, meetings etc.
Testing
Resolves ABA-1465