Skip to content

Redesign poll component #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Redesign poll component #2707

wants to merge 1 commit into from

Conversation

PeterJFB
Copy link
Contributor

@PeterJFB PeterJFB commented May 3, 2022 •
edited
Loading

New poll waddup

poll.mp4

Tooltip is a bit hidden, but will be a one-liner with the new forntpage:)

@PeterJFB PeterJFB mentioned this pull request May 11, 2022
Closed
@PeterJFB PeterJFB force-pushed the nfp-2022-poll branch 2 times, most recently from c8a012c to 58a1f7c Compare May 11, 2022 10:44
eikhr
eikhr reviewed Jun 5, 2022
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing this I noticed that old polls give you the opiton to vote, even though voting is impossible because the polls are no longer valid. This happens with the old component too, so I guess it's not really your responsibility, but it would be super nice if you fixed it. Should be as simple as checking if poll.validUntil is before now, and f.ex. showing results if this is the case.

@PeterJFB
Copy link
Contributor Author

While testing this I noticed that old polls give you the opiton to vote, even though voting is impossible because the polls are no longer valid. This happens with the old component too, so I guess it's not really your responsibility, but it would be super nice if you fixed it. Should be as simple as checking if poll.validUntil is before now, and f.ex. showing results if this is the case.

Nicely spotted! :o
Changed it to instead show results (given they're not hidden) :)

ivarnakken
ivarnakken requested changes Jun 26, 2022
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a step in the right direction! 😍 However, I do have some comments

@ivarnakken
Copy link
Member

Tooltip is a bit hidden, but will be a one-liner with the new forntpage:)

Also, I don't get this. Please make it perfect from the beginning. I thought we agreed that we'd merge these into master, and get one component at a time into prod? At least that's more agile™️

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features need-before-2050 Pull requests that have been in progress for far too long review-needed Pull requests that need review changes-requested Pull requests with requested changes labels Jun 26, 2022
@PeterJFB PeterJFB force-pushed the nfp-2022-poll branch 2 times, most recently from 9470381 to dfb91e2 Compare June 26, 2022 14:36
@PeterJFB
Copy link
Contributor Author

PeterJFB commented Jun 26, 2022 •
edited
Loading

Tooltip is a bit hidden, but will be a one-liner with the new forntpage:)

Also, I don't get this. Please make it perfect from the beginning. I thought we agreed that we'd merge these into master, and get one component at a time into prod? At least that's more agiletm

No:)
See #2697

The final conclusion was to use the plan stated in the pr above
And I unfortunately won't spend time to make it look nice on the current frontpage:)

@PeterJFB PeterJFB force-pushed the nfp-2022-poll branch 4 times, most recently from 1337042 to 74a4da0 Compare June 27, 2022 10:01
ivarnakken
ivarnakken reviewed Jun 27, 2022
View reviewed changes
@PeterJFB PeterJFB force-pushed the nfp-2022-poll branch 3 times, most recently from 6fa9a34 to ae49e0e Compare June 27, 2022 12:15
ivarnakken
ivarnakken reviewed Jun 27, 2022
View reviewed changes
@PeterJFB
Copy link
Contributor Author

Looks way cleaner now, thanks for all the input @ivarnakken! 😍 Merging this in two days if no additional comments are made, We'll be able to make final design-adjustments in the nfp-release-branch o/:sparkles:

@PeterJFB
Copy link
Contributor Author

If you look really close at the video you see the order of options change whenever the poll is closed / opened (yikes). Removed this "feature" with a useMemo

@ivarnakken
Copy link
Member

Closing this due to being stale for 2 years

@ivarnakken ivarnakken closed this Feb 10, 2024
@norbye norbye mentioned this pull request Feb 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eikhr eikhr eikhr left review comments

@ivarnakken ivarnakken ivarnakken requested changes

@EliHaugu EliHaugu Awaiting requested review from EliHaugu

@mattiastofte mattiastofte Awaiting requested review from mattiastofte

Assignees

No one assigned

Labels

changes-requested Pull requests with requested changes enhancement Pull requests that make enhancements, instead of just purely new features need-before-2050 Pull requests that have been in progress for far too long review-needed Pull requests that need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PeterJFB @ivarnakken @eikhr