-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-ui): List and DataList components #4542
Open
leopuleo
wants to merge
20
commits into
feat/new-admin-ui
Choose a base branch
from
leo/feat/ui-list
base: feat/new-admin-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er type safety and flexibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this pull request, we introduce two new components:
List
andDataList
.These two components are utilised to present data across various admin app views. The
List
component serves as the foundational element and is used internally byDataList
, which displays data along with additional props necessary for functionalities such as filtering and ordering, etc.With this PR, we refactored the views that are using
DataList
to:Breaking changes
.DataList
component: now the icons used are imported directly from@material-design-icons/svg/outline
set.Breaking changes
Previously, developers could use any component as direct
children
ofList.ListItem
. This is no longer possible; to ensure the correct positioning, the appropriateList.ListItem
child tag must now be used (i.e.:<ListItemTextPrimary />
).Example:
Missing from the design
active
andselected
state.Other improvements
FormComponentProps
now acceptTValue
generic for theonChange
prop.IconPicker
namespace to not collide with other components such asIcon
.extendTailwindMerge
for enhanced merging.Screenshots
Important
The changes have been applied to the left side of the screen. We still need to refactor the right side.