-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility Mode, the easy part. #488
Conversation
Enable WebGPU Compatibility Mode for all samples that can run unmodified in that mode.
Change looks fine, but I wanted to confirm the expected behavior:
Correct? If so, LGTM! |
The sample will start getting using a compat (but d3d12/vulkan/metal) device in this case, but since the samples don't use any compat features it doesn't have an effect except for a little extra runtime validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, Kai! LGTM, I just wanted to ensure this wasn't going to inadvertently downgrade the adapters for these samples.
This reverts commit 0ce1ef2.
We realized this will break in Chrome <133 with |
This reverts commit 0ce1ef2.
Enable WebGPU Compatibility Mode for all samples that can run unmodified in that mode.