docs: new JS page and updated elements page#1026
Open
laurenic0l wants to merge 12 commits into
Open
Conversation
laurenic0l
requested review from
EHandtkeBasis,
MatthewHawkins,
bbrennanbasis,
gosteenBASIS and
hyyan
as code owners
June 29, 2026 06:16
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hyyan
force-pushed
the
add-execute-javascript-page
branch
from
June 29, 2026 09:41
90b8922 to
1823eac
Compare
EHandtkeBasis
approved these changes
Jun 29, 2026
EHandtkeBasis
left a comment
EHandtkeBasis
left a comment
Member
There was a problem hiding this comment.
Fixed only bug i found, LGTM
hyyan
requested changes
Jun 29, 2026
hyyan
left a comment
hyyan
left a comment
Member
There was a problem hiding this comment.
Rename the demos so their names reflect their content, and ensure the tests are updated to match.
Member
|
@laurenic0l also please link the issues |
Contributor
Author
|
@hyyan done, done, and done! please let me know if there's anything else |
hyyan
added
the
status: waiting-for-review
Member
|
@laurenic0l please fix all conflicts |
hyyan
added
status: waiting-for-author
hyyan
requested changes
Jul 14, 2026
hyyan
left a comment
hyyan
left a comment
Member
There was a problem hiding this comment.
There are conflicts with the main branch that need to be resolved first. I've also left a few change requests, in addition to the following:
- Make sure all demos are responsive.
- Document
callJsFunctionVoidAsync. - I noticed that "Event" and "Event Options" are still not covered. Are these going to be a separate PR? Also, their order in the sidebar is wrong: "Event Options" appears before "Event." I think "Event" should come first, and it should be linked from other articles.
laurenic0l
force-pushed
the
add-execute-javascript-page
branch
from
July 15, 2026 02:29
20a9e86 to
df6b6e7
Compare
laurenic0l
added
status: waiting-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Execute JavaScript page
A dedicated page for the three
HasJsExecutionmethods (executeJs,executeJsAsync,executeJsVoidAsync) at both thePageandElementlevel, with a clipboard "copy invite link" demo.Elements page cleanup
The old "Executing JavaScript" section just duplicated the new page, so it's now a pointer to it.
callJsFunctionstays since it's Element-specific.Element demos refreshed
All four demos got reworked into real-world examples
The "Adding events" section on the Elements page is still small that duplicates
events.md, so I deliberately left it alone since it belongs with the events work rather than this PR.Follow up: merge
events.mdandevent-options.mdinto one page, documentEventDispatcher, and then come back to the Elements page and replace the events stub with a pointer.closes #1033
closes #1032