feat: upgrading client component script and including new workflow to automatically regenerate these.#1009
Open
MatthewHawkins wants to merge 4 commits into
Open
Conversation
…automatically regenerate these.
MatthewHawkins
requested review from
EHandtkeBasis,
bbrennanbasis,
gosteenBASIS,
hyyan and
laurenic0l
as code owners
June 17, 2026 19:16
hyyan
added
the
status: waiting-for-review
EHandtkeBasis
approved these changes
Jun 29, 2026
bbrennanbasis
changed the title
- Removed unused parts in client component docs (imports, br tags, etc.) - Doesn't load a DocChip if the client component doesn't have encapsulation
bbrennanbasis
requested changes
Jul 8, 2026
bbrennanbasis
left a comment
bbrennanbasis
left a comment
Member
There was a problem hiding this comment.
Changes I made:
- Removed unused parts in client component docs (imports, br tags, etc.)
- Doesn't load a DocChip if the client component doesn't have encapsulation (I saw
<DocChip chip='none' />being loaded)
My only suggestion is to have the workflow show as a failure if create_files.js throws an error.
Comment on lines
+32
to
+44
|
|
||
| - name: Commit and push regenerated docs | ||
| run: | | ||
| git config --local user.email "${{ secrets.ACTOR_EMAIL }}" | ||
| git config --local user.name "${{ secrets.ACTOR_NAME }}" | ||
|
|
||
| if [ -n "$(git status --porcelain docs/docs/client-components/)" ]; then | ||
| git add docs/docs/client-components/ | ||
| git commit -m "chore: regenerate client component docs" | ||
| git push | ||
| else | ||
| echo "::notice::No changes in client component docs - nothing to commit" | ||
| fi |
Member
There was a problem hiding this comment.
@MatthewHawkins, don't we want to have the action shown as failed if create_files.js throws an error instead of failing silently?
bbrennanbasis
added
status: waiting-for-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…automatically regenerate these.