Skip to content

Handle multiline leading comments#44

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
grinstead:grinstead/comments
Apr 7, 2026
Merged

Handle multiline leading comments#44
christian-bromann merged 1 commit intowebdriverio:mainfrom
grinstead:grinstead/comments

Conversation

@grinstead
Copy link
Copy Markdown
Contributor

The current parser does not handle multiline comments well.

Comment parsing is in general a bit rough, as this still fails to handle trailing comments at the end of the object for instance. However, I am using the parser and want to support multiline leadins in particular, so this is a minimal pull request making that work.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 6, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: grinstead / name: Joe Grinstead (7e60343)

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit fcb6c7b into webdriverio:main Apr 7, 2026
7 checks passed
@grinstead grinstead deleted the grinstead/comments branch April 7, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants