중복 제거 및 완료 버튼 수정 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlshoon
commented
May 12, 2023
Comment on lines
+38
to
+40
| if (e.type === "keypress" && e.key !== "Enter") { | ||
| return; | ||
| } |
There was a problem hiding this comment.
수정할 때 엔터를 누르면 저장이 되는데 완료를 누르면 저장이 안되더라구요.. 그래서 keypress도 추가 했습니다!
| const [newText, setNewTest] = useState(todoItem.text); | ||
| const [edited, setEdited] = useState(false); | ||
| const [newText, setNewText] = useState(todoItem.text); |
Comment on lines
+17
to
+23
| const updateTodoList = (update) => { | ||
| setTodoList( | ||
| todoList.map((item) => | ||
| item.id === todoItem.id ? { ...item, ...update(item) } : item | ||
| ) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
onChangeCheckbox, onClickSubmitButton, onClickDeleteButton 함수에서 map 함수를 사용하여 새로운 todoList를 생성하는 부분이 반복되고 있습니다. 이 부분을 별도의 함수로 분리했습니다.
Comment on lines
-17
to
-25
| const onChangeCheckbox = () => { | ||
| const nextTodoList = todoList.map((item) => ({ | ||
| ...item, | ||
| // id 값이 같은 항목의 checked 값을 Toggle 함 | ||
| checked: item.id === todoItem.id ? !item.checked : item.checked, | ||
| })); | ||
|
|
||
| setTodoList(nextTodoList); | ||
| }; |
There was a problem hiding this comment.
updateTodoList 함수를 사용하면 이 반복 코드를 줄일 수 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 남깁니다.
TodoList 기능 잘 구현이 됐습니다. 저도 잘 모르는 부분이 있어서 보면서 배웠습니다!! 몇가지 수정사항이 있어서 남깁니다.