Add test for display:none animation on nested pseudo#58054
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Add test for display:none animation on nested pseudo#58054chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Add test to confirm that animating to or from display:none with nested pseudos does not crash. This is a followup addressing a comment raised on the following review: https://chromium-review.googlesource.com/c/chromium/src/+/7595838 The animation introduced on the view-transition-group has no practical use case that I'm aware of. The test is simply to ensure that we don't crash and complete the view-transition successfully. The animations on pseudos within the group automatically restart when the group is no longer display:none in alignment with the spec. Bug: 487225935 Change-Id: Ibfc95413464c1ba8abf6b0d305a1c06068217e0e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to confirm that animating to or from display:none
with nested pseudos does not crash.
This is a followup addressing a comment raised on the following
review:
https://chromium-review.googlesource.com/c/chromium/src/+/7595838
The animation introduced on the view-transition-group has no
practical use case that I'm aware of. The test is simply to ensure
that we don't crash and complete the view-transition successfully.
The animations on pseudos within the group automatically restart
when the group is no longer display:none in alignment with the
spec.
Bug: 487225935
Change-Id: Ibfc95413464c1ba8abf6b0d305a1c06068217e0e
Reviewed-on: https://chromium-review.googlesource.com/7604572
WPT-Export-Revision: 5031b0f4ff0848423b879243550bc55d6ee61654