Create roles-minimum.tentative.html #44934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for minimum role in html aam w3c/html-aam#454
cookiecrook
requested changes
Mar 29, 2024
html-aam/roles-minimum.html
Outdated
| </head> | ||
| <body> | ||
|
|
||
| <p>Tests minimum computedrole mappings defined in <a href="https://w3c.github.io/html-aam/#minimum-role">HTML-AAM</a>, where the returned computed role for generic elements is expected to change based on the generic elements having attributes that would require the element no longer be generic, and potentially ignored by browsers. Most test names correspond to a unique ID defined in the spec.<p> |
There was a problem hiding this comment.
Since this isn't landed yet (dead spec link), I'd expect to see a link to the issue that cross-references the proposed spec diff, implementation trackers, etc.
There was a problem hiding this comment.
issue link could be removed at the time that everything is merged and the test file loses its tentative status.
change file name to include .tentative
|
Kicking the WPT CI bots by closing/reopening. |
cookiecrook
reviewed
Apr 18, 2024
scottaohara
changed the title
cookiecrook
changed the title
cookiecrook
reviewed
Jun 14, 2024
cookiecrook
approved these changes
Jun 14, 2024
cookiecrook
reviewed
Jun 17, 2024
|
Will merge once the CI tests complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for minimum role in html aam
related to w3c/html-aam#454