Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update html/ from monorail results #807

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Update html/ from monorail results #807

merged 3 commits into from
Feb 3, 2021

Conversation

stephenmcgruer
Copy link
Contributor

See #798 for methodology

@stephenmcgruer stephenmcgruer added the do not merge yet Disable auto-merge label Feb 1, 2021
stephenmcgruer
stephenmcgruer commented Feb 1, 2021
View reviewed changes
html/browsers/browsing-the-web/history-traversal/META.yml Outdated Show resolved Hide resolved
html/dom/META.yml Outdated Show resolved Hide resolved
html/semantics/forms/the-input-element/META.yml Outdated Show resolved Hide resolved
html/webappapis/scripting/events/META.yml Outdated Show resolved Hide resolved
html/webappapis/scripting/processing-model-2/META.yml Outdated Show resolved Hide resolved
html/semantics/scripting-1/the-script-element/module/dynamic-import/META.yml Outdated Show resolved Hide resolved
html/semantics/scripting-1/the-template-element/definitions/META.yml Outdated Show resolved Hide resolved
html/semantics/text-level-semantics/the-wbr-element/META.yml Outdated Show resolved Hide resolved
html/syntax/parsing/META.yml Outdated Show resolved Hide resolved
html/webappapis/scripting/events/META.yml Outdated Show resolved Hide resolved
@stephenmcgruer
Copy link
Contributor Author

@foolip - PTAL.

I did my own first pass using https://docs.google.com/spreadsheets/d/1AJFl3gLfVFjOXRAir9g2BsesdF3fGp9LJHnDtWQLW-c/edit#gid=0 to look for meta bugs etc. Feel free to review my comments and the second commit if you want to validate them at all.

@foolip
Copy link
Member

foolip commented Feb 2, 2021

Thanks @stephenmcgruer! I'll just do some spot checking of what still remains in the PR.

foolip
foolip reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed especially the bugs with with many tests linked to them, and spot checked some of the rest. Overall looks great!

html/canvas/element/text-styles/META.yml Show resolved Hide resolved
html/canvas/offscreen/text/META.yml Outdated Show resolved Hide resolved
html/semantics/embedded-content/media-elements/loading-the-media-resource/META.yml Show resolved Hide resolved
foolip
foolip requested changes Feb 2, 2021
View reviewed changes
html/canvas/element/text-styles/META.yml Outdated Show resolved Hide resolved
html/canvas/element/text-styles/META.yml Show resolved Hide resolved
@foolip foolip merged commit f301f2a into master Feb 3, 2021
@foolip foolip deleted the smcgruer/html branch February 3, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@foolip foolip foolip approved these changes

Assignees

@foolip foolip

Labels
do not merge yet Disable auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenmcgruer @foolip