Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should use chunk in path data of compilation.getPath #8032

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Sep 30, 2024

Summary

fix #7960

Not support chunk contenthash yet, need to add contentHashType field, perhaps should support it in the future

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 30, 2024
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2b1c584
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67061e1a7b93f000085504e0

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 30, 2024
@LingyuCoder LingyuCoder marked this pull request as draft September 30, 2024 09:23
@LingyuCoder LingyuCoder changed the title fix: should use chunk in path data of compilation.getPath fix: should use existing chunk in path data of compilation.getPath Sep 30, 2024
@LingyuCoder LingyuCoder force-pushed the fix/compilation-get-path-chunk branch from 5faaa19 to 5d962a8 Compare October 8, 2024 10:48
@LingyuCoder LingyuCoder changed the title fix: should use existing chunk in path data of compilation.getPath fix: should use chunk in path data of compilation.getPath Oct 9, 2024
@LingyuCoder LingyuCoder marked this pull request as ready for review October 9, 2024 06:42
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 9, 2024 06:58
@LingyuCoder LingyuCoder merged commit f8f850e into main Oct 9, 2024
30 checks passed
@LingyuCoder LingyuCoder deleted the fix/compilation-get-path-chunk branch October 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: license-webpack-plugin will not replace "[name]" in "outputFilename"
2 participants