refactor: add JSDoc to improve Rspack configuration.entry|context|mode types #8016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
GiveMe-A-Name
changed the title
GiveMe-A-Name
changed the title
GiveMe-A-Name
force-pushed
the
refactor/configuration-entry-types
branch
from
483d5cb
to
eac1ead
Compare
GiveMe-A-Name
requested review from
ahabhgk and
h-a-n-a
and removed request for
ahabhgk
GiveMe-A-Name
force-pushed
the
refactor/configuration-entry-types
branch
from
eac1ead
to
10116d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…context] types.
Zod types system is not easy to understand by user.
We tend use raw ts provider intellisense and jsDoc for user in ide.
See #4241 more detail.
Summary
Checklist