Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): kick async task first #7986

Closed
wants to merge 1 commit into from
Closed

Conversation

hardfist
Copy link
Contributor

Summary

currently we run job by FIFO order which may cause async job is blocked by sync job, so try to kick async job first so it can run parallel with sync job

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d515e35
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f41a038988be0008ecfdff

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 25, 2024
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 25, 2024

📝 Benchmark detail: Open

Name Base (2024-09-25 5fd46ef) Current Change
10000_development-mode + exec 2.27 s ± 30 ms 2.25 s ± 27 ms -0.79 %
10000_development-mode_hmr + exec 701 ms ± 15 ms 706 ms ± 13 ms +0.70 %
10000_production-mode + exec 2.93 s ± 20 ms 2.9 s ± 23 ms -1.04 %
arco-pro_development-mode + exec 1.84 s ± 80 ms 1.86 s ± 85 ms +0.92 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.9 ms 437 ms ± 3.6 ms +0.08 %
arco-pro_production-mode + exec 3.32 s ± 72 ms 3.29 s ± 100 ms -0.94 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.35 s ± 98 ms 3.36 s ± 81 ms +0.32 %
threejs_development-mode_10x + exec 1.7 s ± 17 ms 1.71 s ± 9.9 ms +0.56 %
threejs_development-mode_10x_hmr + exec 788 ms ± 9.3 ms 806 ms ± 9.1 ms +2.31 %
threejs_production-mode_10x + exec 5.26 s ± 11 ms 5.29 s ± 23 ms +0.40 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants