-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: cache swc loader #7965
Merged
chenjiahan
merged 3 commits into
web-infra-dev:main
from
CPunisher:perf/cache-swc-loader
Oct 18, 2024
Merged
perf: cache swc loader #7965
chenjiahan
merged 3 commits into
web-infra-dev:main
from
CPunisher:perf/cache-swc-loader
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: performance
release: performance related release(mr only)
label
Sep 24, 2024
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
!bench |
📝 Benchmark detail: Open
|
Thanks. Modules in our bench cases are not that many, so the benefits may not be so obvious, but personally I think it's great for some large projects |
@JSerFeng can we merge this |
!eco-ci |
CPunisher
force-pushed
the
perf/cache-swc-loader
branch
from
October 12, 2024 07:21
e798cba
to
dd1b3be
Compare
CPunisher
force-pushed
the
perf/cache-swc-loader
branch
from
October 12, 2024 14:51
a0bc2b2
to
e0e0f29
Compare
sure, I'll approve once this is not draft |
JSerFeng
approved these changes
Oct 14, 2024
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Assume:
SwcLoaderJsOptions
is costlyCost:
RwLock
and concurrent runtime.Maybe there is a better cache strategy.
🙏 Help me run the benchmark.