Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): try run task in spawn thread #7943

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Sep 22, 2024

Summary

currently we run parse in working thread which may cause blocking the working thread, try put parse in separate rayon thread instead

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 22, 2024
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3a084fa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f0d5819946ca0008a25c47

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

⏳ Triggered benchmark: Open

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 22, 2024

📝 Benchmark detail: Open

Name Base (2024-09-22 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 36 ms 2.49 s ± 39 ms +11.16 %
10000_development-mode_hmr + exec 706 ms ± 10 ms 723 ms ± 8.9 ms +2.38 %
10000_production-mode + exec 2.9 s ± 33 ms 3.14 s ± 29 ms +8.18 %
arco-pro_development-mode + exec 1.88 s ± 64 ms 1.99 s ± 35 ms +5.93 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.8 ms 442 ms ± 5.5 ms +1.27 %
arco-pro_production-mode + exec 3.31 s ± 59 ms 3.51 s ± 115 ms +5.94 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 64 ms 3.52 s ± 115 ms +4.38 %
threejs_development-mode_10x + exec 1.69 s ± 15 ms 1.77 s ± 14 ms +5.11 %
threejs_development-mode_10x_hmr + exec 803 ms ± 8.6 ms 822 ms ± 17 ms +2.36 %
threejs_production-mode_10x + exec 5.26 s ± 17 ms 5.34 s ± 46 ms +1.38 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","threejs_development-mode_10x + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 22, 2024

📝 Benchmark detail: Open

Name Base (2024-09-22 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 36 ms 2.12 s ± 24 ms -5.41 %
10000_development-mode_hmr + exec 706 ms ± 10 ms 706 ms ± 6.6 ms +0.06 %
10000_production-mode + exec 2.9 s ± 33 ms 2.8 s ± 30 ms -3.24 %
arco-pro_development-mode + exec 1.88 s ± 64 ms 1.86 s ± 47 ms -1.09 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.8 ms 435 ms ± 3.4 ms -0.14 %
arco-pro_production-mode + exec 3.31 s ± 59 ms 3.34 s ± 68 ms +0.68 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 64 ms 3.42 s ± 87 ms +1.39 %
threejs_development-mode_10x + exec 1.69 s ± 15 ms 1.7 s ± 17 ms +1.08 %
threejs_development-mode_10x_hmr + exec 803 ms ± 8.6 ms 798 ms ± 7.7 ms -0.69 %
threejs_production-mode_10x + exec 5.26 s ± 17 ms 5.27 s ± 31 ms +0.14 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 22, 2024

📝 Benchmark detail: Open

Name Base (2024-09-22 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 36 ms 2.12 s ± 32 ms -5.16 %
10000_development-mode_hmr + exec 706 ms ± 10 ms 707 ms ± 15 ms +0.11 %
10000_production-mode + exec 2.9 s ± 33 ms 2.79 s ± 32 ms -3.84 %
arco-pro_development-mode + exec 1.88 s ± 64 ms 1.81 s ± 66 ms -3.68 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.8 ms 435 ms ± 2.7 ms -0.25 %
arco-pro_production-mode + exec 3.31 s ± 59 ms 3.32 s ± 70 ms +0.21 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 64 ms 3.35 s ± 98 ms -0.68 %
threejs_development-mode_10x + exec 1.69 s ± 15 ms 1.71 s ± 16 ms +1.54 %
threejs_development-mode_10x_hmr + exec 803 ms ± 8.6 ms 798 ms ± 7.6 ms -0.66 %
threejs_production-mode_10x + exec 5.26 s ± 17 ms 5.27 s ± 27 ms +0.09 %

@hardfist hardfist marked this pull request as ready for review September 22, 2024 16:39
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 22, 2024

📝 Benchmark detail: Open

Name Base (2024-09-22 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 36 ms 2.11 s ± 16 ms -5.82 %
10000_development-mode_hmr + exec 706 ms ± 10 ms 684 ms ± 8.5 ms -3.13 %
10000_production-mode + exec 2.9 s ± 33 ms 2.75 s ± 21 ms -5.01 %
arco-pro_development-mode + exec 1.88 s ± 64 ms 1.82 s ± 66 ms -3.33 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.8 ms 435 ms ± 3.1 ms -0.13 %
arco-pro_production-mode + exec 3.31 s ± 59 ms 3.29 s ± 77 ms -0.88 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 64 ms 3.34 s ± 76 ms -0.94 %
threejs_development-mode_10x + exec 1.69 s ± 15 ms 1.7 s ± 12 ms +0.93 %
threejs_development-mode_10x_hmr + exec 803 ms ± 8.6 ms 796 ms ± 6.8 ms -0.93 %
threejs_production-mode_10x + exec 5.26 s ± 17 ms 5.26 s ± 19 ms -0.13 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 22, 2024

📝 Benchmark detail: Open

Name Base (2024-09-22 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 36 ms 2.11 s ± 20 ms -5.95 %
10000_development-mode_hmr + exec 706 ms ± 10 ms 676 ms ± 12 ms -4.23 %
10000_production-mode + exec 2.9 s ± 33 ms 2.73 s ± 25 ms -5.97 %
arco-pro_development-mode + exec 1.88 s ± 64 ms 1.83 s ± 86 ms -2.60 %
arco-pro_development-mode_hmr + exec 436 ms ± 2.8 ms 434 ms ± 2.7 ms -0.35 %
arco-pro_production-mode + exec 3.31 s ± 59 ms 3.31 s ± 106 ms -0.00 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.37 s ± 64 ms 3.34 s ± 86 ms -0.75 %
threejs_development-mode_10x + exec 1.69 s ± 15 ms 1.7 s ± 15 ms +1.13 %
threejs_development-mode_10x_hmr + exec 803 ms ± 8.6 ms 798 ms ± 11 ms -0.59 %
threejs_production-mode_10x + exec 5.26 s ± 17 ms 5.25 s ± 28 ms -0.31 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 23, 2024

📝 Benchmark detail: Open

Name Base (2024-09-23 45a3997) Current Change
10000_development-mode + exec 2.25 s ± 35 ms 2.36 s ± 30 ms +4.69 %
10000_development-mode_hmr + exec 715 ms ± 26 ms 708 ms ± 6.7 ms -0.95 %
10000_production-mode + exec 2.89 s ± 22 ms 2.98 s ± 55 ms +3.06 %
arco-pro_development-mode + exec 1.85 s ± 70 ms 1.94 s ± 92 ms +4.89 %
arco-pro_development-mode_hmr + exec 437 ms ± 1.2 ms 440 ms ± 5.3 ms +0.67 %
arco-pro_production-mode + exec 3.31 s ± 98 ms 3.36 s ± 56 ms +1.38 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.35 s ± 70 ms 3.46 s ± 76 ms +3.33 %
threejs_development-mode_10x + exec 1.7 s ± 15 ms 1.85 s ± 99 ms +9.20 %
threejs_development-mode_10x_hmr + exec 795 ms ± 6.7 ms 830 ms ± 14 ms +4.45 %
threejs_production-mode_10x + exec 5.27 s ± 33 ms 5.69 s ± 251 ms +7.98 %

Threshold exceeded: ["threejs_development-mode_10x + exec","threejs_production-mode_10x + exec"]

@hardfist hardfist marked this pull request as draft September 23, 2024 03:35
@hardfist
Copy link
Contributor Author

I don't know why rayon improve bu block_in_place degrade

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 23, 2024

📝 Benchmark detail: Open

Name Base (2024-09-23 45a3997) Current Change
10000_development-mode + exec 2.25 s ± 35 ms 2.32 s ± 37 ms +3.02 %
10000_development-mode_hmr + exec 715 ms ± 26 ms 713 ms ± 19 ms -0.35 %
10000_production-mode + exec 2.89 s ± 22 ms 2.96 s ± 36 ms +2.43 %
arco-pro_development-mode + exec 1.85 s ± 70 ms 1.94 s ± 75 ms +5.33 %
arco-pro_development-mode_hmr + exec 437 ms ± 1.2 ms 439 ms ± 3.5 ms +0.37 %
arco-pro_production-mode + exec 3.31 s ± 98 ms 3.4 s ± 77 ms +2.56 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.35 s ± 70 ms 3.44 s ± 94 ms +2.69 %
threejs_development-mode_10x + exec 1.7 s ± 15 ms 1.83 s ± 37 ms +7.93 %
threejs_development-mode_10x_hmr + exec 795 ms ± 6.7 ms 826 ms ± 45 ms +3.95 %
threejs_production-mode_10x + exec 5.27 s ± 33 ms 5.47 s ± 305 ms +3.89 %

Threshold exceeded: ["arco-pro_development-mode + exec","threejs_development-mode_10x + exec"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants