-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): try run task in spawn thread #7943
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspack canceled.
|
!bench |
⏳ Triggered benchmark: Open |
2fbda57
to
bc8c73c
Compare
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","threejs_development-mode_10x + exec"] |
bc8c73c
to
696f506
Compare
!bench |
📝 Benchmark detail: Open
|
!bench |
📝 Benchmark detail: Open
|
!bench |
📝 Benchmark detail: Open
|
!bench |
📝 Benchmark detail: Open
|
b2d06b1
to
3a084fa
Compare
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["threejs_development-mode_10x + exec","threejs_production-mode_10x + exec"] |
I don't know why rayon improve bu block_in_place degrade |
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["arco-pro_development-mode + exec","threejs_development-mode_10x + exec"] |
Summary
currently we run parse in working thread which may cause blocking the working thread, try put parse in separate rayon thread instead
Checklist