fix(plugins): make rust plugin stage compatible with webpack #7942
+44
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
pawel-twardziak
force-pushed
the
fix/rust-plugin-stage-not-compatible-with-webpack
branch
2 times, most recently
from
6fa723a
to
149dd33
Compare
|
can you add test about it, try pass Infinity to stage and see whether it works |
|
@hardfist sure, will do and let you know |
pawel-twardziak
force-pushed
the
fix/rust-plugin-stage-not-compatible-with-webpack
branch
2 times, most recently
from
4a7f682
to
d55e2a9
Compare
hardfist
reviewed
Sep 25, 2024
| @@ -1419,7 +1419,7 @@ impl NormalModuleFactoryResolve for NormalModuleFactoryResolveTap { | |||
| } | |||
|
|
|||
| fn stage(&self) -> i32 { | |||
pawel-twardziak
force-pushed
the
fix/rust-plugin-stage-not-compatible-with-webpack
branch
from
b995597
to
e4afa28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
see #7862
Checklist