-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): add new javascript parser options #7939
Conversation
✅ Deploy Preview for rspack canceled.
|
8ed9800
to
f00b9d4
Compare
efa5cf5
to
0cad17d
Compare
0cad17d
to
49c38fe
Compare
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/import_parser_plugin.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the current implementation, but we should keep it as experiment for now, or at least hide it from docs, and wait for implementing it in webpack to have a more stable implementation
Sure. Any why to make it as experimental now? Or just using name like |
An experimental warning in jsdoc and hide these options from rspack docs looks good to me |
Summary
Fix web-infra-dev/rslib#204 and more.
We'll try to merge this back into webpack after stabilized.
Checklist