Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): add new javascript parser options #7939

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Sep 20, 2024

Summary

Fix web-infra-dev/rslib#204 and more.

We'll try to merge this back into webpack after stabilized.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f889147
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67065673f6622b00089d0bff

@fi3ework fi3ework force-pushed the parser-flags branch 2 times, most recently from 8ed9800 to f00b9d4 Compare September 23, 2024 08:01
@fi3ework fi3ework force-pushed the parser-flags branch 2 times, most recently from efa5cf5 to 0cad17d Compare September 29, 2024 09:32
@fi3ework fi3ework marked this pull request as ready for review September 29, 2024 09:32
@fi3ework fi3ework requested review from LingyuCoder and removed request for LingyuCoder September 29, 2024 09:35
@fi3ework fi3ework marked this pull request as draft September 29, 2024 16:43
@fi3ework fi3ework marked this pull request as ready for review September 30, 2024 06:19
@fi3ework fi3ework requested review from ahabhgk and removed request for LingyuCoder October 8, 2024 04:02
ahabhgk
ahabhgk previously approved these changes Oct 9, 2024
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the current implementation, but we should keep it as experiment for now, or at least hide it from docs, and wait for implementing it in webpack to have a more stable implementation

@fi3ework
Copy link
Member Author

fi3ework commented Oct 9, 2024

I am ok with the current implementation, but we should keep it as experiment for now, or at least hide it from docs,

Sure. Any why to make it as experimental now? Or just using name like experimenalRequireResolve or rspackRequireResolve. I think adding an experimental warning in jsdoc is enough.

@ahabhgk
Copy link
Collaborator

ahabhgk commented Oct 9, 2024

An experimental warning in jsdoc and hide these options from rspack docs looks good to me

@fi3ework fi3ework requested a review from ahabhgk October 9, 2024 10:42
@ahabhgk ahabhgk merged commit 5416306 into web-infra-dev:main Oct 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: external should handle require.resolve
2 participants