Skip to content

fix: fix dot-notation test #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+178 −53
Open

fix: fix dot-notation test #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f4dd6b
fix: fix dot-notation test
hardfist Sep 15, 2025
f6627fb
Merge branch 'main' into fix-dot-notation
ScriptedAlchemy Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/rslint/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"os"
"sort"
"sync"

"github.com/microsoft/typescript-go/shim/ast"
Expand Down Expand Up @@ -219,6 +220,16 @@ func (h *IPCHandler) HandleLint(req api.LintRequest) (*api.LintResponse, error)
if diagnostics == nil {
diagnostics = []api.Diagnostic{}
}
// sort diagnostics
sort.Slice(diagnostics, func(i, j int) bool {
if diagnostics[i].FilePath != diagnostics[j].FilePath {
return diagnostics[i].FilePath < diagnostics[j].FilePath
}
if diagnostics[i].Range.Start.Line != diagnostics[j].Range.Start.Line {
return diagnostics[i].Range.Start.Line < diagnostics[j].Range.Start.Line
}
return diagnostics[i].Range.Start.Column < diagnostics[j].Range.Start.Column
})

// Create response
response := &api.LintResponse{
Expand Down
2 changes: 1 addition & 1 deletion internal/rules/dot_notation/dot_notation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ var DotNotationRule = rule.CreateRule(rule.Rule{
replacement := objectText + whitespace + "." + propName

// Report on the node with the fix
ctx.ReportNodeWithFixes(node, buildUseDotMessage(), rule.RuleFixReplace(ctx.SourceFile, node, replacement))
ctx.ReportNodeWithFixes(elem.ArgumentExpression, buildUseDotMessage(), rule.RuleFixReplace(ctx.SourceFile, node, replacement))
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagnostic is being reported on elem.ArgumentExpression but the fix is applied to the entire node. This mismatch could cause the fix to replace more than the highlighted range, potentially affecting unrelated code.

Suggested change
ctx.ReportNodeWithFixes(elem.ArgumentExpression, buildUseDotMessage(), rule.RuleFixReplace(ctx.SourceFile, node, replacement))
ctx.ReportNodeWithFixes(node, buildUseDotMessage(), rule.RuleFixReplace(ctx.SourceFile, node, replacement))

Copilot uses AI. Check for mistakes.

}
}

Expand Down
Loading
Loading