test: keep rspack eco ci passing after mangle output change#1574
Merged
Timeless0911 merged 1 commit intomainfrom Apr 3, 2026
Merged
test: keep rspack eco ci passing after mangle output change#1574Timeless0911 merged 1 commit intomainfrom
Timeless0911 merged 1 commit intomainfrom
Conversation
Timeless0911
changed the title
JSerFeng
approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Relaxes the node-polyfill integration test assertion so it remains compatible with Rspack’s mangled output, keeping the rspack-eco CI green after upstream output changes.
Changes:
- Update the
Bufferimport detection regex to accept a mangled property name when requiringbuffer/index.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax the node polyfill integration assertion so it accepts the mangled property name emitted by Rspack.
This keeps rspack eco CI passing after web-infra-dev/rspack#13588 changed the generated output during mangle.
Related Links
Checklist