refactor(core): rename Insight class to Service #1386
+175
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a comprehensive refactoring that renames the Insight class and all related types to Service for better semantic clarity. Changes: - Renamed directories: insight/ -> service/ - Renamed test files: insight.test.ts -> service.test.ts - Updated 50+ type definitions - Modified 18+ source files - Synchronized all test files - Updated external package dependencies Core updates: - Class: Insight -> Service - Interface: InsightOptions -> ServiceOptions - All InsightX types -> ServiceX types - String literal 'Insight' -> 'Service' Affected files: - src/index.ts, src/yaml.ts, src/task-runner.ts - src/agent/*.ts (agent, tasks, task-builder, ui-utils) - tests/utils.ts and all test files - External: chrome-extension, evaluation, report Verification: - TypeScript: 0 errors - Lint: 530 files passed - Build: successful (341.1 kB) 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
- Updated ExecutionTaskInsightLocate to ExecutionTaskServiceLocate - Changed task.type check from 'Insight' to 'Service' - Renamed insightTask variable to serviceTask for consistency
quanru
force-pushed
the
refactor/rename-insight-to-service
branch
from
e2bc1af to
6150a7b
Compare
- Updated ExecutionTaskInsightLocate to ExecutionTaskServiceLocate in sidebar, detail-side, and detail-panel components - Changed task.type checks from 'Insight' to 'Service' - Updated ExecutionTaskInsightAssertion to ExecutionTaskServiceAssertion - Ensures report UI displays Service tasks correctly
- Updated aiaction-cacheable.test.ts - Updated page-task-executor-waitFor.test.ts - Completes the Insight to Service refactoring
quanru
force-pushed
the
refactor/rename-insight-to-service
branch
from
e94b4cb to
a03a768
Compare
- Updated task-builder.test.ts expectations - Updated page-task-executor-rightclick.test.ts expectations - Fixes CI test failures
Keep Service class name but restore ExecutionTask type to 'Insight'
for consistency with UI display requirements.
Changes:
- ExecutionTaskType: 'Service' → 'Insight'
- All ExecutionTaskService* types → ExecutionTaskInsight*
- Runtime checks: task.type === 'Service' → task.type === 'Insight'
- ui-utils.ts: Removed special handling for Query/Assert subtypes
to display "Insight / Query" and "Insight / Assert" correctly
Type display now follows the expected pattern:
- Planning / Plan
- Planning / Locate
- Action Space / {interface}
- Insight / Query
- Insight / Assert
- Insight / Locate
Files modified:
- packages/core/src/types.ts
- packages/core/src/agent/*.ts
- packages/core/src/task-runner.ts
- packages/visualizer/src/utils/replay-scripts.ts
- apps/report/src/components/**/*.tsx
- All test files
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs a comprehensive refactoring that renames the
Insightclass and all related types toServicefor better semantic clarity and consistency across the codebase.Changes Overview
Directory and File Structure
packages/core/src/insight/→packages/core/src/service/packages/core/tests/ai/insight/→packages/core/tests/ai/service/insight.test.ts→service.test.tsCore Code Updates
Insight→ServiceInsightOptions→ServiceOptionscreateInsightDump()→createServiceDump()'ai:insight'→'ai:service'Type System Refactoring
All type definitions in
types.tshave been updated:InsightAction→ServiceActionInsightExtractParam→ServiceExtractParamInsightExtractOption→ServiceExtractOptionInsightTaskInfo→ServiceTaskInfoInsightDump→ServiceDumpInsightError→ServiceErrorInsightAssertionResponse→ServiceAssertionResponseExecutionTaskInsight*types →ExecutionTaskService*'Insight'→'Service'in ExecutionTaskTypeFiles Modified (20 files)
Core Package:
src/index.ts- Updated exportssrc/types.ts- 50+ type definitionssrc/yaml.ts- Interface updatessrc/task-runner.ts- Type referencessrc/ai-model/inspect.ts- Parameter typessrc/agent/agent.ts- Class usage and typessrc/agent/tasks.ts- Service instance and typessrc/agent/task-builder.ts- Service instance and typessrc/agent/ui-utils.ts- Type referencesTest Files:
tests/utils.ts- Helper functionstests/ai/service/service.test.ts- Test suitetests/unit-test/*.test.ts- Unit testsExternal Packages:
apps/chrome-extension/src/utils/eventOptimizer.tspackages/evaluation/tests/llm-locator.test.tspackages/evaluation/tests/screenspot-v2-evaluation.test.tsapps/report/src/components/store/index.tsxImpact Analysis
Breaking Changes
InsightclassInsight*typesInsightErrorMigration Guide
Testing & Verification
Build System
✅ TypeScript Compilation: 0 errors
✅ Lint Check: 530 files passed
✅ Build Output: 341.1 kB (successful)
Type Safety
Insightreferences remainingFile Integrity
Checklist
🤖 Generated with Claude Code