fix: make puppeteer external in web-integration (#208)

* fix: make puppeteer external in web-integration * fix: import path of yaml player * fix: import path of yaml player
web-infra-dev · Dec 25, 2024 · cd00680 · cd00680
1 parent 05dad23
commit cd00680
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/cli/src/printer.ts b/packages/cli/src/printer.ts
@@ -3,7 +3,7 @@ import type {
   ScriptPlayerStatusValue,
   ScriptPlayerTaskStatus,
 } from '@midscene/core';
-import { type ScriptPlayer, flowItemBrief } from '@midscene/web';
+import { type ScriptPlayer, flowItemBrief } from '@midscene/web/yaml';
 import chalk from 'chalk';
 
 export interface MidsceneYamlFileContext {

diff --git a/packages/cli/src/yaml-runner.ts b/packages/cli/src/yaml-runner.ts
@@ -1,6 +1,6 @@
 import { readFileSync } from 'node:fs';
 import { basename, extname } from 'node:path';
-import { ScriptPlayer, parseYamlScript } from '@midscene/web';
+import { ScriptPlayer, parseYamlScript } from '@midscene/web/yaml';
 import { createServer } from 'http-server';
 import {
   type MidsceneYamlFileContext,

diff --git a/packages/web-integration/modern.config.ts b/packages/web-integration/modern.config.ts
@@ -20,6 +20,6 @@ export default defineConfig({
       yaml: 'src/yaml/index.ts',
     },
     target: 'es2018',
-    externals: ['@midscene/core', '@midscene/shared'],
+    externals: ['@midscene/core', '@midscene/shared', 'puppeteer'],
   },
 });
diff --git a/packages/web-integration/src/puppeteer/agent-launcher.ts b/packages/web-integration/src/puppeteer/agent-launcher.ts
@@ -1,6 +1,5 @@
 import assert from 'node:assert';
 import { readFileSync } from 'node:fs';
-import puppeteer from 'puppeteer';
 
 import { PuppeteerAgent } from '@/puppeteer';
 import type { MidsceneYamlScriptEnv } from '@midscene/core';
@@ -72,6 +71,7 @@ export async function puppeteerAgentForTarget(
       'you are probably running headed mode in CI, this will usually fail.',
     );
   }
+  const puppeteer = await import('puppeteer');
   const browser = await puppeteer.launch({
     headless: !headed,
     args: [