fix: miss elements under a div

web-infra-dev · Dec 27, 2024 · 2f1a779 · 2f1a779
1 parent 8a8c97f
commit 2f1a779
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/packages/web-integration/src/extractor/dom-util.ts b/packages/web-integration/src/extractor/dom-util.ts
@@ -65,6 +65,10 @@ export function isContainerElement(node: Node): node is HTMLElement {
     return false;
   }
 
+  if (includeUserDescribedElement(node)) {
+    return false;
+  }
+
   const computedStyle = window.getComputedStyle(node);
   const backgroundColor = computedStyle.getPropertyValue('background-color');
   if (backgroundColor) {
@@ -74,6 +78,17 @@ export function isContainerElement(node: Node): node is HTMLElement {
   return false;
 }
 
+function includeUserDescribedElement(node: Node) {
+  if (node instanceof Element) {
+    const selector = `[${USER_DESCRIBED_ELEMENT_ATTRIBUTE_REF}]`;
+    const elements = node.querySelectorAll(selector);
+    if (elements.length > 0) {
+      return true;
+    }
+  }
+  return false;
+}
+
 function includeBaseElement(node: Node) {
   if (!(node instanceof HTMLElement)) return false;
 
@@ -83,6 +98,7 @@ function includeBaseElement(node: Node) {
   }
 
   const includeList = [
+    'canvas',
     'svg',
     'button',
     'input',