Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojerl support #185

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Clojerl support #185

wants to merge 6 commits into from

Conversation

metehan
Copy link

@metehan metehan commented May 12, 2021

No description provided.

@atomist
Copy link

atomist bot commented May 12, 2021

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message subject is over 50 characters.

@weavejester
Copy link
Owner

Many of the conditional expressions have repetition that could be removed. The tests will also need to be fixed, and the CI needs to include tests for Clojerl as well.

@metehan
Copy link
Author

metehan commented May 12, 2021

Ops everything failed. @weavejester could you make an initial check if it's generally ok I can make a cleaner PR. @jfacorro have changed file names to follow https://github.com/clojure/clojurescript/wiki/Using-cljc convention. I guess you wouldn't want some filename changes right?

@weavejester
Copy link
Owner

Using cljc files is fine. The code looks generally okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants