Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore metadata in front of first symbol when looking for matching rules #346

Conversation

camsaul
Copy link
Contributor

@camsaul camsaul commented Aug 20, 2024

I could not get things like

(^:once fn* [x y]
  (+ x y))

to format correctly despite having custom rules for fn*; after digging into things a bit I realized this gets parsed to a metadata node wrapping fn* and token-value doesn't work correctly in this case. Changed token-value to unwrap metadata nodes in this case which means the correct rule is now found and things indent according to the appropriate rule

@weavejester
Copy link
Owner

Thanks for the commit! Can you change the commit message to:

Fix indentation for symbols preceded by metadata

This adds the keyword 'Fix' (useful for searching), and reduced the commit subject to 50 characters or less.

@camsaul camsaul force-pushed the ignore-metadata-on-first-symbol-in-list branch from c01ee51 to 103984e Compare August 20, 2024 15:53
@camsaul
Copy link
Contributor Author

camsaul commented Aug 20, 2024

@weavejester done

@weavejester weavejester merged commit 68d534e into weavejester:master Aug 21, 2024
1 check passed
@weavejester
Copy link
Owner

Merged. Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants