Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dokan dashboard buttons color synchronization issue with dokan color customizer module. #62

Conversation

MdAsifHossainNadim
Copy link
Contributor

@MdAsifHossainNadim MdAsifHossainNadim commented Mar 15, 2024

Sync Dashboard Buttons with Dokan Color Customizer module.

Before this enhancement, we had issues with dashboard buttons not syncing with the Dokan Color Customizer module. Now, it is working fine.

Note: Version bump is required to update/fix this issue

Issue Link: #55

Previous this Fix :
color-issue-first

After this Fix :
Screenshot 2024-03-15 at 11 08 56 AM

@shohag121
Copy link
Member

Note: Version bump is required to update/fix this issue

@MdAsifHossainNadim Bhai, Would you please explain a little?

@MdAsifHossainNadim
Copy link
Contributor Author

MdAsifHossainNadim commented Mar 15, 2024

@shohag121 Vhaiya, When we used the color palette's preset from dokan color customizer modules, the preset's color combination works fine on vendor dashboard navigation & others. But some places like vendor product page button not reflected perfectly when dokani theme activated. Because, we are using important clause with our styles from theme end.

Also, currently, we cached few theme relevant css on dokani_dynamic_css_output key. So, we need to re-genarate this css or use upgrader for impact this fixes. We have a function named dokani_set_dynamic_css_cache in dokani theme for re-generate theme css & it will be triggered if version update.

@MdAsifHossainNadim MdAsifHossainNadim changed the title [Fix] : dashboard-buttons-synchronization-issue-with-dokan-color-customizer fix: Dokan dashboard buttons color synchronization issue with dokan color customizer module. Mar 15, 2024
@MdAsifHossainNadim
Copy link
Contributor Author

@shashwatahalder01 Vhai, kindly check this pr at your convenience.
NB:- We need to remove dokani_dynamic_css_output key (for bast caching or regenerate style first) from options table before starting this testing.

@MdAsifHossainNadim MdAsifHossainNadim merged commit 4eb1aba into weDevsOfficial:develop Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants