issue350 #362
Open
issue350 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razbakov
requested changes
Mar 29, 2023
| @@ -109,7 +334,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div v-if="profile.type !== 'City'" class="flex space-x-2 p-4 justify-end"> | |||
| <!-- <div v-if="profile.type !== 'City'" class="flex space-x-2 p-4 justify-end"> | |||
There was a problem hiding this comment.
You can comment code locally, when you develop, but please don't commit commented code
| export default { | ||
| async asyncData() { | ||
| const pageId = $nuxt.$route.params.id | ||
| const docRef = db.collection('profiles').doc(pageId) |
There was a problem hiding this comment.
You should find document in collection nfc-cards, please see acceptance criteria
| @@ -0,0 +1,7 @@ | |||
| <template> | |||
| <main> | |||
| <div>nfc</div> | |||
There was a problem hiding this comment.
No need for this file, it is not in acceptance criteria
| name="undraw_profile_pic" | ||
| class="w-full rounded-full" | ||
| /> | ||
| <div class="h-48 relative"> |
There was a problem hiding this comment.
Please refactor this file, use components
|
PR title doesn't meet requirements described in Dev Workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pleast test the redirect function and new header of the TProfile.
How to test the redirect function:
1.Go to pages: /nfc/[id]
id can be get from firebase profiles. For example:/nfc/niVQ86nvS6Oiqv2L4sFLgWnZQQQ2