Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Order the Card #360

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Order the Card #360

wants to merge 3 commits into from

Conversation

fhareed1
Copy link

@fhareed1 fhareed1 commented Mar 28, 2023

How to test:

  1. Open the demo link.
  2. Click Get Free VIP card.
  3. See the Shop to order the card.

Demo: https://wedancefareed.netlify.app/fhareed

Closes #348

@fhareed1 fhareed1 self-assigned this Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for wedancefareed ready!

Name Link
🔨 Latest commit 7b41cca
🔍 Latest deploy log https://app.netlify.com/sites/wedancefareed/deploys/6422f378900e940009b89df0
😎 Deploy Preview https://deploy-preview-360--wedancefareed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fhareed1 fhareed1 closed this Mar 28, 2023
@fhareed1 fhareed1 reopened this Mar 28, 2023
@fhareed1 fhareed1 closed this Mar 28, 2023
@fhareed1 fhareed1 reopened this Mar 28, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't delete it just renamed it to .env

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't rename it. you should copy it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you see in this pull request, it shows that you deleted this file. revert this change.

</script>

<style>
.text {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use inline styles. Use Tailwind classes. See how other components are done. Do it similar.

@@ -1,5 +1,6 @@
<template>
<div>
<template v-if="!uid"><TOrderButton /></template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not an order button. Think more abstract.
It's a banner. It functionality should be similar to WTeaser.

@@ -143,6 +138,11 @@
class="w-full mt-4"
/>

<TCommunity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you rebase your code on top of main branch.
This code change has nothing to do with your task. Make sure you don't break things.

@@ -302,6 +296,9 @@ import {
import { useCities } from '~/use/cities'

export default {
components: {
TOrderButton,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt is doing auto-import of components. No need to define components, they are already available.

@razbakov
Copy link
Contributor

Make a better title and description of this pull request. Include a preview link in description.

@fhareed1 fhareed1 changed the title Demo fhareed feat: Order the Card Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order the card
2 participants